7phs commented on code in PR #1755:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1755#discussion_r1994036934
##########
src/dialect/snowflake.rs:
##########
@@ -245,6 +245,14 @@ impl Dialect for SnowflakeDialect {
.map(|p|
Some(ColumnOption::Policy(ColumnPolicy::ProjectionPolicy(p)))))
} else if parser.parse_keywords(&[Keyword::TAG]) {
Ok(parse_column_tags(parser, with).map(|p|
Some(ColumnOption::Tags(p))))
+ } else if parser.parse_keywords(&[Keyword::COMMENT]) {
+ let next_token = parser.next_token();
+ match next_token.token {
+ Token::DollarQuotedString(value, ..) => {
+ Ok(Ok(Some(ColumnOption::Comment(value.value))))
+ }
+ _ => Err(ParserError::ParserError("not found
match".to_string())),
Review Comment:
That makes sense. I have moved this code to the parser level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
