joroKr21 commented on code in PR #15149: URL: https://github.com/apache/datafusion/pull/15149#discussion_r1996627243
########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -6232,12 +6244,12 @@ select array_intersect(arrow_cast([1, 1, 2, 2, 3, 3], 'LargeList(Int64)'), null) query ? select array_intersect(null, [1, 1, 2, 2, 3, 3]); ---- -NULL +[] Review Comment: Above we have ``` query ? select array_intersect([1, 1, 2, 2, 3, 3], null); ---- [] ``` So I think it's better that `array_intersect` is commutative. I can make both `null` or both empty list but I think it should be the same if we flip the arguments. Which one should it be? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
