jayzhan211 commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r1996487546


##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -1563,8 +1563,12 @@ async fn with_column_join_same_columns() -> Result<()> {
         \n  Limit: skip=0, fetch=1\
         \n    Sort: t1.c1 ASC NULLS FIRST\
         \n      Inner Join: t1.c1 = t2.c1\
-        \n        TableScan: t1\
-        \n        TableScan: t2",
+        \n        SubqueryAlias: t1\

Review Comment:
   You can check the `into_optimized_plan` below, we have the consistent result.
   
   It includes analyzer and optimizer. That is why the main branch doesn't have 
subquery before optimization, and we have it after `inline_tablescan` is called.
   In this change, since inline table scan is called inside plan building, so 
we got this subquery before optimization



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to