alamb commented on code in PR #15284:
URL: https://github.com/apache/datafusion/pull/15284#discussion_r1999606913
##########
datafusion/catalog/src/session.rs:
##########
@@ -145,7 +145,7 @@ impl From<&dyn Session> for TaskContext {
state.scalar_functions().clone(),
state.aggregate_functions().clone(),
state.window_functions().clone(),
- state.runtime_env().clone(),
+ Arc::clone(state.runtime_env()),
Review Comment:
this shows what the lint disallows -- when it is an `Arc` it must use
`Arc::clone` rather than `.clone()` so it is easier to see when reading the
code that no copies are made
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
