changsun20 commented on issue #14434:
URL: https://github.com/apache/datafusion/issues/14434#issuecomment-2731465313
Hi @eliaperantoni,
Thank you for the detailed guidance! Here's my understanding of the next
steps:
1. **Warning Scope**
I'll implement the semantic approach to only raise warnings when `= NULL`
is used as a condition, which makes the most sense functionally.
2. **Warning Plumbing**
Both approaches you outlined are helpful. I'll start with the interior
mutability approach using `warnings: RefCell<Vec<Diagnostic>>` in `SqlToRel` as
it seems to be the least disruptive path forward. The `DatafusionResult` type
with `WarningAccumulator` pattern offers an interesting, more robust solution
that we could consider for the longer term.
3. **Span Highlighting**
I've checked PR
[#1738](https://github.com/apache/datafusion-sqlparser-rs/pull/1738) and found
that the feature is available in `sqlparser` version 0.55.0. However, the main
codebase can't be upgraded to this version directly at the moment. There's a
WIP PR(#15183) for this dependency upgrade, so I believe this won't be a
problem soon.
Thanks again for your guidance. I'll start working on an implementation
based on these suggestions. Appreciate your patience as I navigate the codebase!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
