jsai28 commented on code in PR #15288:
URL: https://github.com/apache/datafusion/pull/15288#discussion_r2001387282
##########
datafusion/core/tests/sql/select.rs:
##########
@@ -30,23 +30,7 @@ async fn test_list_query_parameters() -> Result<()> {
.with_param_values(vec![ScalarValue::from(3i32)])?
.collect()
.await?;
- let expected = vec![
- "+----+----+-------+",
- "| c1 | c2 | c3 |",
- "+----+----+-------+",
- "| 3 | 1 | false |",
- "| 3 | 10 | true |",
- "| 3 | 2 | true |",
- "| 3 | 3 | false |",
- "| 3 | 4 | true |",
- "| 3 | 5 | false |",
- "| 3 | 6 | true |",
- "| 3 | 7 | false |",
- "| 3 | 8 | true |",
- "| 3 | 9 | false |",
- "+----+----+-------+",
- ];
- assert_batches_sorted_eq!(expected, &results);
+ assert_snapshot!(batches_to_sort_string(&results));
Review Comment:
missing inline snapshot
##########
datafusion/core/tests/sql/select.rs:
##########
@@ -66,33 +50,7 @@ async fn test_named_query_parameters() -> Result<()> {
])?
.collect()
.await?;
- let expected = vec![
- "+----+----+",
- "| c1 | c2 |",
- "+----+----+",
- "| 1 | 1 |",
- "| 1 | 2 |",
- "| 1 | 3 |",
- "| 1 | 4 |",
- "| 1 | 5 |",
- "| 1 | 6 |",
- "| 1 | 7 |",
- "| 1 | 8 |",
- "| 1 | 9 |",
- "| 1 | 10 |",
- "| 2 | 1 |",
- "| 2 | 2 |",
- "| 2 | 3 |",
- "| 2 | 4 |",
- "| 2 | 5 |",
- "| 2 | 6 |",
- "| 2 | 7 |",
- "| 2 | 8 |",
- "| 2 | 9 |",
- "| 2 | 10 |",
- "+----+----+",
- ];
- assert_batches_sorted_eq!(expected, &results);
+ assert_snapshot!(batches_to_sort_string(&results));
Review Comment:
missing inline snapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
