parthchandra commented on code in PR #1555:
URL: https://github.com/apache/datafusion-comet/pull/1555#discussion_r2003816293
##########
native/core/src/parquet/mod.rs:
##########
@@ -641,6 +640,8 @@ pub unsafe extern "system" fn
Java_org_apache_comet_parquet_Native_initRecordBat
session_timezone: jstring,
) -> jlong {
try_unwrap_or_throw(&e, |mut env| unsafe {
+ let task_ctx = TaskContext::default();
Review Comment:
The difference here is that this is really an API called by the Java code.
This path does not have a
[PhysicalPlanner](https://github.com/apache/datafusion-comet/blob/3c1fc06c465f668800d747f3feb6295340c3329b/native/core/src/execution/planner.rs#L147C12-L147C27)
and consequently does not have access to the Session or Task context used by a
native operator.
Also, not really sure if it makes a performance difference. But I'm fine
with this change as long as it doesn't break anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
