alamb commented on code in PR #15327:
URL: https://github.com/apache/datafusion/pull/15327#discussion_r2005971323
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -793,8 +793,10 @@ impl BinaryExpr {
BitwiseShiftRight => bitwise_shift_right_dyn(left, right),
BitwiseShiftLeft => bitwise_shift_left_dyn(left, right),
StringConcat => concat_elements(left, right),
- AtArrow | ArrowAt => {
- unreachable!("ArrowAt and AtArrow should be rewritten to
function")
+ AtArrow | ArrowAt | Arrow | LongArrow | HashArrow | HashLongArrow
| AtAt
+ | HashMinus | AtQuestion | Question | QuestionAnd | QuestionPipe
+ | IntegerDivide => {
+ unreachable!("These operators should be rewritten to
functions")
Review Comment:
I dont think this code is unreachable -- I got it to panic:
```shell
DataFusion CLI v46.0.1
> select 'foo' @> 'bar';
thread 'main' panicked at
datafusion/physical-expr/src/expressions/binary.rs:799:17:
internal error: entered unreachable code: These operators should be
rewritten to functions
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
