nathschmidt opened a new pull request, #1083:
URL: https://github.com/apache/datafusion-python/pull/1083
# Which issue does this PR close?
Closes #1082
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
This change adds a `PyClientOptions` wrapper around
`object_store.ClientOptions` so that it can be instantiated and then used from
Python.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Introduces a new `PyClientOptions` struct and necessary wiring to use it.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
New optional user-facing arguments for setting `ClientOptions`.
Given this is my first change - and I don't usually work in Rust - looking
to get some confirmation on approach and acceptability of this PR.
Outstanding TODO's:
- [ ] Get some confirmation on overall approach
- [ ] Add necessary wiring for all contexts
- [ ] Add some simple tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
