parthchandra commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2017071919
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2722,7 +2721,11 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
case op
if isCometSink(op) && op.output.forall(a =>
- supportedDataType(a.dataType, allowComplex = true)) =>
+ supportedDataType(
+ a.dataType,
+ allowComplex =
+ usingDataFusionParquetExec(conf) ||
CometConf.COMET_CONVERT_FROM_PARQUET_ENABLED
Review Comment:
This check seems fine. Could could get a complex type in a CometSink if
either of these conditions is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
