comphead commented on code in PR #1550:
URL: https://github.com/apache/datafusion-comet/pull/1550#discussion_r2020248798
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -490,8 +490,7 @@ object CometScanExec extends DataTypeSupport {
// TODO add map
dt match {
case s: StructType => s.fields.map(_.dataType).forall(isTypeSupported)
- // TODO: Add nested array and iceberg compat support
- // case a: ArrayType => isTypeSupported(a.elementType)
+ case a: ArrayType => isTypeSupported(a.elementType)
Review Comment:
Thanks @parthchandra I'm planning to merge it and add more array tests as
followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
