alamb opened a new issue, #15465:
URL: https://github.com/apache/datafusion/issues/15465

   ### Is your feature request related to a problem or challenge?
   
   For some reason the DataFusion version of the ClickBench queries use the 
`to_timestamp_seconds` function:
   
https://github.com/apache/datafusion/blob/46f4024577f4e13b79d8739849ecf51af5ddc7c2/benchmarks/queries/clickbench/queries.sql#L24
   
   However that function does timestamp validation and potentially slows down 
queries and prevents other optimizations (for example what @adriangb  is doing 
in https://github.com/apache/datafusion/pull/15301)
   
   
    I checked and DuckDB simply uses `EventTime`
   
   
https://github.com/ClickHouse/ClickBench/blob/bdc6e32589c2785a66ccee98904a322c5e5d3f50/duckdb/queries.sql#L24C1-L25C1
   
   As does `ClickHouse`
   
https://github.com/ClickHouse/ClickBench/blob/bdc6e32589c2785a66ccee98904a322c5e5d3f50/clickhouse/queries.sql#L24
   
   
   ### Describe the solution you'd like
   
   Ideally the queries would be updated so they do not use to_timestamp_seconds
   
   For example
   ```sql
   SELECT * FROM 'hits.parquet' WHERE "URL" LIKE '%google%' ORDER BY 
"EventTime" LIMIT 10
   ```
   
   
   ### Describe alternatives you've considered
   
   1. Update queries in this repo
   2. Update the queries in the clickbench repository as well: 
https://github.com/ClickHouse/ClickBench/blob/bdc6e32589c2785a66ccee98904a322c5e5d3f50/datafusion/queries.sql
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to