acking-you commented on code in PR #15462:
URL: https://github.com/apache/datafusion/pull/15462#discussion_r2019944906
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -358,7 +358,50 @@ impl PhysicalExpr for BinaryExpr {
fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> {
use arrow::compute::kernels::numeric::*;
+ fn check_short_circuit(arg: &ColumnarValue, op: &Operator) -> bool {
Review Comment:
> Is there any reason to have this function defined in the evaluate method?
There was no particular reason. Maybe I couldn't find a suitable place to
write it at the time, haha.
> If we find that this slows down some other performance we could also add
some sort of heuristic check to calling false_count / true_count -- like for
example if the rhs arg is "complex" (not a Column for example)
I also agree that
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -358,7 +358,50 @@ impl PhysicalExpr for BinaryExpr {
fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> {
use arrow::compute::kernels::numeric::*;
+ fn check_short_circuit(arg: &ColumnarValue, op: &Operator) -> bool {
Review Comment:
> Is there any reason to have this function defined in the evaluate method?
There was no particular reason. Maybe I couldn't find a suitable place to
write it at the time, haha.
> If we find that this slows down some other performance we could also add
some sort of heuristic check to calling false_count / true_count -- like for
example if the rhs arg is "complex" (not a Column for example)
I also agree that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
