Kontinuation commented on code in PR #1581:
URL: https://github.com/apache/datafusion-comet/pull/1581#discussion_r2029234073
##########
native/core/src/execution/jni_api.rs:
##########
@@ -262,8 +277,11 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_createPlan(
fn prepare_datafusion_session_context(
batch_size: usize,
memory_pool: Arc<dyn MemoryPool>,
+ local_dirs: Vec<String>,
) -> CometResult<SessionContext> {
- let mut rt_config =
RuntimeEnvBuilder::new().with_disk_manager(DiskManagerConfig::NewOs);
+ let disk_manager_config =
+
DiskManagerConfig::NewSpecified(local_dirs.into_iter().map(PathBuf::from).collect());
Review Comment:
It is not possible. All file operations performed by Spark's
[DiskBlockManager](
https://github.com/apache/spark/blob/v4.0.0-rc3/core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala)
are using `java.io.File` and `java.nio.file.Files` so it only supports local
filesystem. No object store paths should be used for initializing
`DiskManagerConfig` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
