andygrove commented on code in PR #1573:
URL: https://github.com/apache/datafusion-comet/pull/1573#discussion_r2021092431
##########
spark/src/main/spark-3.5/org/apache/spark/sql/comet/shims/ShimCometScanExec.scala:
##########
@@ -55,15 +55,48 @@ trait ShimCometScanExec {
protected def isNeededForSchema(sparkSchema: StructType): Boolean = false
protected def getPartitionedFile(f: FileStatusWithMetadata, p:
PartitionDirectory): PartitionedFile =
- PartitionedFileUtil.getPartitionedFile(f, f.getPath, p.values)
+ try {
+ PartitionedFileUtil.getPartitionedFile(f, f.getPath, p.values)
+ } catch {
+ case _: NoSuchMethodError =>
Review Comment:
> Reflection is ok with me. I just wanted to make sure we dropped 3.5.4
support If we decide to support 3.5.4 as community, I think we should test with
3.5.4 (downgrade in pom) all the way
@kazuyukitanimura I filed
https://github.com/apache/datafusion-comet/issues/1579 to continue this
discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
