geoffreyclaude commented on code in PR #15653:
URL: https://github.com/apache/datafusion/pull/15653#discussion_r2035646883
##########
datafusion/common-runtime/src/common.rs:
##########
@@ -15,18 +15,23 @@
// specific language governing permissions and limitations
// under the License.
-use std::future::Future;
+use std::{
+ future::Future,
+ pin::Pin,
+ task::{Context, Poll},
+};
-use crate::JoinSet;
-use tokio::task::JoinError;
+use tokio::task::{JoinError, JoinHandle};
Review Comment:
Good catch @gabotechs! Yes, pretty much. For both to be compatible, the same
wrapping I implemented over the `tokio::task::JoinSet` probably needs to be
done over `tokio::task::spawn` and `tokio::task::spawn_blocking`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
