parthchandra commented on code in PR #1619:
URL: https://github.com/apache/datafusion-comet/pull/1619#discussion_r2036090192
##########
native/core/src/parquet/mod.rs:
##########
@@ -703,6 +704,7 @@ pub unsafe extern "system" fn
Java_org_apache_comet_parquet_Native_initRecordBat
file_groups,
None,
data_filters,
+ pushdown_filters != 0,
Review Comment:
Same here. `data_filters` is an `Option` and should be `None` if filter
pushdown is disabled.
##########
common/src/main/java/org/apache/comet/parquet/Native.java:
##########
@@ -257,7 +257,8 @@ public static native long initRecordBatchReader(
byte[] requiredSchema,
byte[] dataSchema,
String sessionTimezone,
- int batchSize);
+ int batchSize,
+ boolean pushdownFilters);
Review Comment:
This is already implied if the filter parameter is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
