iffyio commented on code in PR #1809:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1809#discussion_r2072719447
##########
src/parser/mod.rs:
##########
@@ -475,6 +475,10 @@ impl<'a> Parser<'a> {
if expecting_statement_delimiter && word.keyword ==
Keyword::END {
break;
}
+
Review Comment:
@aharpervc Sorry for the delay getting back to this, actually I'm leaning
towards not merging this feature after all unfortunately. It feels to me like
there's a bit too many special cases (like this extending the core parsing loop
for example) for this feature that go against the normal of sql statement
parsing. And combined with this feature not being part of any sql reference but
rather a specific tool, it makes the tradeoff undesirable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
