zhuqi-lucas commented on code in PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#discussion_r2132112459
##########
datafusion/physical-optimizer/src/wrap_leaves_cancellation.rs:
##########
@@ -76,7 +77,8 @@ impl WrapLeaves {
plan: Arc<dyn ExecutionPlan>,
yield_frequency: usize,
) -> Result<Transformed<Arc<dyn ExecutionPlan>>> {
- let is_pipeline_breaker = plan.properties().emission_type ==
EmissionType::Final;
+ // todo this is a bit of a hack, we should probably have a more
explicit way to handle
+ let is_pipeline_breaker = plan.properties().emission_type ==
EmissionType::Final|| plan.as_any().is::<FilterExec>();
Review Comment:
This code was removed by me, and we need to find a better solution for the
filter and join corner cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
