Re: [PR] feat: Allow cancelling of grouping operations which are CPU bound [datafusion]

Fri, 06 Jun 2025 08:28:56 -0700 


zhuqi-lucas commented on PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#issuecomment-2949615347

   Good result, removed all ignore, corner cases all passed:
   
   ```rust
   running 18 tests
   test 
execution::infinite_cancel::test_infinite_join_agg_cancel::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_agg_cancel::pretend_finite_1_false 
... ok
   test 
execution::infinite_cancel::test_infinite_agg_cancel::pretend_finite_2_true ... 
ok
   test 
execution::infinite_cancel::test_infinite_join_cancel::pretend_finite_1_false 
... ok
   test 
execution::infinite_cancel::test_filter_reject_all_batches_cancel::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_filter_reject_all_batches_cancel::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_join_cancel::pretend_finite_2_true 
... ok
   test 
execution::infinite_cancel::test_infinite_join_agg_cancel::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_hash_join_without_repartition_and_no_agg::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_hash_join_without_repartition_and_no_agg::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_interleave_agg_cancel::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_interleave_cancel::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_interleave_agg_cancel::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_interleave_cancel::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_sort_merge_join_without_repartition_and_no_agg::pretend_finite_1_false
 ... ok
   test 
execution::infinite_cancel::test_infinite_sort_merge_join_without_repartition_and_no_agg::pretend_finite_2_true
 ... ok
   test 
execution::infinite_cancel::test_infinite_sort_cancel::pretend_finite_1_false 
... ok
   test 
execution::infinite_cancel::test_infinite_sort_cancel::pretend_finite_2_true 
... ok
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to