zhuqi-lucas commented on code in PR #16196:
URL: https://github.com/apache/datafusion/pull/16196#discussion_r2135356171
##########
datafusion/sqllogictest/test_files/explain.slt:
##########
@@ -242,6 +242,7 @@ physical_plan after OutputRequirements DataSourceExec:
file_groups={1 group: [[W
physical_plan after LimitAggregation SAME TEXT AS ABOVE
Review Comment:
Because, we added the built-in leaf nodes which will have built-in
YieldStream, so the rule will ignore those cases. And almost all cases should
have built-in YieldStream currently, so it will not add extra YieldStreamExec.
But if customer use custom leaf operator node, it will automatically add the
YieldStreamExec, this is expected.
##########
datafusion/physical-optimizer/src/optimizer.rs:
##########
@@ -137,6 +138,7 @@ impl PhysicalOptimizer {
// are not present, the load of executors such as join or union
will be
// reduced by narrowing their input tables.
Arc::new(ProjectionPushdown::new()),
+ Arc::new(WrapLeaves::new()),
Review Comment:
Good suggestion @alamb , i will address this, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
