alamb commented on issue #15914: URL: https://github.com/apache/datafusion/issues/15914#issuecomment-2964396824
I just had a chat with @shehabgamin The current status is that we have not smoothed out the process to the point where contributors with minimal context can pick up a porting ticket and be successful porting the functions upstream. It seems writing / having tests tests are the last missing piece before we have a high likelihood of achieving this goal. Here is the plan we came up with (please correct me if I am wrong): 1. @shehabgamin will create a script that creates expected `.slt` files from the sail gold master expected output (what @linhr describes on https://github.com/apache/datafusion/issues/15914#issuecomment-2935366003). 2. @shehabgamin will make a PR that checks in that pre-generated `.slt` files that are disabled somehow 3. We will then make a PR that shows a function being ported over and enabling the relevant `.slt` file (maybe it can be @irenjj 's https://github.com/apache/datafusion/pull/15958) Then @alamb will create (copy/paste style) tickets for the remaining functions (based on https://github.com/apache/datafusion/issues/15916) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
