berkaysynnada commented on PR #16322:
URL: https://github.com/apache/datafusion/pull/16322#issuecomment-2965717965
> > if the pending rotation somehow breaks, since SortPreservingMergeStream
never yields
>
> I'm not sure I understand what you mean @berkaysynnada. Looking at just
the initial phase it should still yield after each round of polling if there
are any pending streams.
I mean when we remove this incremental (that's how I test that
test_spm_congestion covers this rotation):
```
// The polled stream is pending which means we're
already set up to
// be woken when necessary
// Try the next stream
idx += 1;
```
the test never finishes. But as I said, not a big deal as the test is
written in that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
