theirix commented on code in PR #16325: URL: https://github.com/apache/datafusion/pull/16325#discussion_r2146926102
########## datafusion/sql/tests/sql_integration.rs: ########## @@ -4714,3 +4714,115 @@ fn test_using_join_wildcard_schema() { ] ); } + +#[test] Review Comment: Reworked tests in slt files, covered extra cases. I have included explanations in the code regarding the handling of system vs row sampling. The remaining part is handling joins (subqueries work fine, verified with integration tests). I put a TODO about it to address in a future PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org