kazuyukitanimura commented on code in PR #1911:
URL: https://github.com/apache/datafusion-comet/pull/1911#discussion_r2155755872
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -1946,6 +1946,52 @@ class ParquetReadV1Suite extends ParquetReadSuite with
AdaptiveSparkPlanHelper {
}
}
}
+
+ test("read basic complex types") {
+ Seq(true, false).foreach(dictionaryEnabled => {
+ withTempPath { dir =>
+ val path = new Path(dir.toURI.toString, "complex_types.parquet")
+ makeParquetFileComplexTypes(path, dictionaryEnabled, 10)
+ withParquetTable(path.toUri.toString, "complex_types") {
+ Seq(CometConf.SCAN_NATIVE_DATAFUSION,
CometConf.SCAN_NATIVE_ICEBERG_COMPAT).foreach(
+ scanMode => {
+ withSQLConf(CometConf.COMET_NATIVE_SCAN_IMPL.key -> scanMode) {
+ checkSparkAnswer(sql("select * from complex_types"))
Review Comment:
Perhaps we can create a ticket to include `map_entries` in this test once it
is supported?
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -1946,6 +1946,52 @@ class ParquetReadV1Suite extends ParquetReadSuite with
AdaptiveSparkPlanHelper {
}
}
}
+
+ test("read basic complex types") {
+ Seq(true, false).foreach(dictionaryEnabled => {
+ withTempPath { dir =>
+ val path = new Path(dir.toURI.toString, "complex_types.parquet")
+ makeParquetFileComplexTypes(path, dictionaryEnabled, 10)
+ withParquetTable(path.toUri.toString, "complex_types") {
+ Seq(CometConf.SCAN_NATIVE_DATAFUSION,
CometConf.SCAN_NATIVE_ICEBERG_COMPAT).foreach(
+ scanMode => {
+ withSQLConf(CometConf.COMET_NATIVE_SCAN_IMPL.key -> scanMode) {
+ checkSparkAnswer(sql("select * from complex_types"))
Review Comment:
Thanks. Perhaps we can create a ticket to include `map_entries` in this test
once it is supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
