UBarney commented on PR #16443: URL: https://github.com/apache/datafusion/pull/16443#issuecomment-2993919183
> When you are running the benchmarks do they stay consistent? Yes. bechmarks result almost consistent. I ran the benchmarks a few minutes ago on commit. It's worth noting that the join type in query 3 (q3) was modified from a right join to a left join. | ID | SQL | join_base Time(s) | join_limit_join_batch_size Time(s) | Performance Change | |----|-----|-------------|------------|-------------------| | 1 | select t1.value from range(8192) t1 join range(8192) t2 on t1.value + t2.value < t1.value * t2.value; | 0.821 | 0.559 | +31.89% | | 2 | select t1.value from range(8192) t1 join range(8192) t2 on t1.value + t2.value > t1.value * t2.value; | 0.633 | 0.367 | +41.99% | | 3 | select t1.value from range(8192) t1 left join range(8192) t2 on t1.value + t2.value > t1.value * t2.value; | 0.632 | 0.365 | +42.29% | | 4 | select t1.value from range(8192) t1 join range(81920) t2 on t1.value + t2.value < t1.value * t2.value; | Failed | 1.495 | N/A | | 5 | select t1.value from range(100) t1 join range(819200) t2 on t1.value + t2.value > t1.value * t2.value; | 0.285 | 0.072 | +74.81% | | 6 | select t1.value from range(100) t1 join range(819200) t2 on t1.value + t2.value < t1.value * t2.value; | 0.392 | 0.172 | +56.13% | | SQL Query | join_base Memory | join_limit_join_batch_size Memory | Improvement | |-----------|----------------|---------------------------------|-------------| | select t1.value from range(8192) t1 join range(8192) t2 on t1.value + t2.value < t1.value * t2.value; | 2.82 GB | 1.57 GB | ↓ 44.2% | | select t1.value from range(8192) t1 join range(8192) t2 on t1.value + t2.value > t1.value * t2.value; | 2.83 GB | 857.4 MB | ↓ 70.4% | | select t1.value from range(8192) t1 left join range(8192) t2 on t1.value + t2.value > t1.value * t2.value; | 2.82 GB | 847.6 MB | ↓ 70.7% | | select t1.value from range(8192) t1 join range(81920) t2 on t1.value + t2.value < t1.value * t2.value; | 26.51 GB ❌ (exit code: 137) | 15.11 GB | N/A (process failed) | | select t1.value from range(100) t1 join range(819200) t2 on t1.value + t2.value > t1.value * t2.value; | 1008.6 MB | 330.4 MB | ↓ 67.2% | | select t1.value from range(100) t1 join range(819200) t2 on t1.value + t2.value < t1.value * t2.value; | 1.35 GB | 652.1 MB | ↓ 52.7% | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
