hsiang-c commented on code in PR #1920:
URL: https://github.com/apache/datafusion-comet/pull/1920#discussion_r2167786141
##########
common/src/main/java/org/apache/comet/parquet/FileReader.java:
##########
@@ -209,6 +257,55 @@ public void setRequestedSchema(List<ColumnDescriptor>
projection) {
}
}
+ /** This method is called from Apache Iceberg. */
+ public void setRequestedSchemaFromSpecs(List<ParquetColumnSpec> specList) {
+ paths.clear();
+ for (ParquetColumnSpec colSpec : specList) {
+ ColumnDescriptor descriptor = Utils.buildColumnDescriptor(colSpec);
+ paths.put(ColumnPath.get(colSpec.getPath()), descriptor);
+ }
+ }
+
+ private static ParquetReadOptions buildParquetReadOptions(
+ Configuration conf,
+ Map<String, String> properties,
+ Long start,
+ Long length,
+ byte[] fileEncryptionKey,
+ byte[] fileAADPrefix) {
+
+ Collection<String> readPropertiesToRemove =
+ Sets.newHashSet(
+ "parquet.read.filter",
Review Comment:
Could we use these constants since they are not in the method signature?
```java
ParquetInputFormat.UNBOUND_RECORD_FILTER,
ParquetInputFormat.FILTER_PREDICATE,
ParquetInputFormat.READ_SUPPORT_CLASS,
EncryptionPropertiesFactory.CRYPTO_FACTORY_CLASS_PROPERTY_NAME
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
