adamreeve commented on code in PR #16351:
URL: https://github.com/apache/datafusion/pull/16351#discussion_r2167883986
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -930,12 +959,14 @@ pub async fn fetch_parquet_metadata(
store: &dyn ObjectStore,
meta: &ObjectMeta,
size_hint: Option<usize>,
+ decryption_properties: Option<&FileDecryptionProperties>,
Review Comment:
This looks like a breaking change (and same for `fetch_statistics`). Should
we introduce a new method with this parameter added to avoid breaking the API?
It is documented as "subject to change" though so maybe this is ok...
##########
datafusion/common/src/config.rs:
##########
@@ -2017,6 +2056,305 @@ config_namespace_with_hashmap! {
}
}
+#[derive(Clone, Debug, Default, PartialEq)]
+pub struct ConfigFileEncryptionProperties {
+ /// Should the parquet footer be encrypted
+ pub encrypt_footer: bool,
Review Comment:
Footer encryption should probably be enabled by default, which I think means
we need to explicitly implement the Default trait.
##########
datafusion/proto-common/src/from_proto/mod.rs:
##########
@@ -1066,6 +1066,7 @@ impl TryFrom<&protobuf::TableParquetOptions> for
TableParquetOptions {
.unwrap(),
column_specific_options,
key_value_metadata: Default::default(),
+ crypto: Default::default(),
Review Comment:
If we aren't going to support conversion to protobuf yet, we should probably
raise an error in `impl TryFrom<&TableParquetOptions> for
protobuf::TableParquetOptions` if any crypto options are set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
