irenjj commented on code in PR #16611:
URL: https://github.com/apache/datafusion/pull/16611#discussion_r2173675299
##########
datafusion/optimizer/src/decorrelate_dependent_join.rs:
##########
@@ -165,30 +174,52 @@ impl DependentJoinDecorrelator {
}
}
fn new(
- correlated_columns: &Vec<(usize, Column, DataType)>,
- parent_correlated_columns: &IndexMap<usize, Vec<CorrelatedColumnInfo>>,
+ node: &DependentJoin,
+ // correlated_columns: &Vec<(usize, Column, DataType)>,
+ parent_correlated_columns: &mut IndexMap<usize,
Vec<CorrelatedColumnInfo>>,
Review Comment:
We can push depth info into CorrelatedColumnInfo, for
decrrelate_dependent_join, what it really cares about is OuterRefColumn depth
and lateral join.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
