Kimahriman commented on issue #1819: URL: https://github.com/apache/datafusion-comet/issues/1819#issuecomment-3016859181
Wondering if it makes sense to convert some of these. Specifically the two I added: - `GetStructField`: DataFusion has a similar `get_field` already we could use, but it operates by field name instead of index, so it has to find the right field by name for each batch which adds some overhead, which is some of the downside it seems to the UDFs over logical and physical expressions which can optimize these cases at analysis time. Implementing a custom ScalarUDF also doesn't really make sense because as a user you would never select a nested field by index, always by name. - `GetArrayStructFields`: There's no equivalent DataFusion expression AFAIK, but the same thing above applies where there's not really a use cases for using this function directly, Spark just creates this at analysis time from an `ExtractValue` operation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
