yoavcloud commented on code in PR #1912:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1912#discussion_r2177485063
##########
src/dialect/mod.rs:
##########
@@ -1060,6 +1060,22 @@ pub trait Dialect: Debug + Any {
fn supports_space_separated_column_options(&self) -> bool {
false
}
+
+ /// Returns true if the dialect supports `ALTER TABLE tbl ALTER COLUMN col
TYPE <type>`
+ /// without specifying `SET DATA` before `TYPE`.
+ ///
+ /// -
[Redshift](https://docs.aws.amazon.com/redshift/latest/dg/r_ALTER_TABLE.html#r_ALTER_TABLE-synopsis)
+ /// -
[PostgreSQL](https://www.postgresql.org/docs/current/sql-altertable.html)
+ fn supports_alter_column_type_without_set(&self) -> bool {
Review Comment:
Yes that is an option. I hesitated a bit because saw specific negative
tests, and did not want to break anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
