rishvin commented on PR #1971: URL: https://github.com/apache/datafusion-comet/pull/1971#issuecomment-3034298009
> > @andygrove : Could you please review and check if this is how you envisioned these changes? > > Thanks @rishvin. I took a first pass through, and this looks great. Thanks for adding comprehensive tests both in Scala and Rust. I do wonder if we should implement the expression as a `ScalarUDFImpl` rather than `PhysicalExpr` though. What do you think? Thanks @andygrove , yes SGTM. Let me rewrite these changes as UDF. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
