adriangb commented on PR #16433: URL: https://github.com/apache/datafusion/pull/16433#issuecomment-3036131650
I did a bench run, confounding results: ``` ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ topk-filters ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ Q1 │ 9.96 ms │ 10.70 ms │ 1.07x slower │ │ Q2 │ 12.63 ms │ 15.30 ms │ 1.21x slower │ │ Q3 │ 33.45 ms │ 35.22 ms │ 1.05x slower │ │ Q4 │ 15.22 ms │ 16.82 ms │ 1.11x slower │ │ Q5 │ 9.87 ms │ 8.85 ms │ +1.12x faster │ │ Q6 │ 16.54 ms │ 22.16 ms │ 1.34x slower │ │ Q7 │ 43.41 ms │ 44.00 ms │ no change │ │ Q8 │ 22.91 ms │ 34.56 ms │ 1.51x slower │ │ Q9 │ 38.68 ms │ 39.60 ms │ no change │ │ Q10 │ 65.73 ms │ 73.24 ms │ 1.11x slower │ │ Q11 │ 34.78 ms │ 37.14 ms │ 1.07x slower │ └──────────────┴──────────┴──────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩ │ Total Time (main) │ 303.17ms │ │ Total Time (topk-filters) │ 337.58ms │ │ Average Time (main) │ 27.56ms │ │ Average Time (topk-filters) │ 30.69ms │ │ Queries Faster │ 1 │ │ Queries Slower │ 8 │ │ Queries with No Change │ 2 │ │ Queries with Failure │ 0 │ └─────────────────────────────┴──────────┘ ``` Mostly... slower -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
