jkosh44 commented on code in PR #16608: URL: https://github.com/apache/datafusion/pull/16608#discussion_r2186149622
########## datafusion/substrait/src/variation_const.rs: ########## @@ -53,6 +53,10 @@ pub const DATE_64_TYPE_VARIATION_REF: u32 = 1; pub const DEFAULT_CONTAINER_TYPE_VARIATION_REF: u32 = 0; pub const LARGE_CONTAINER_TYPE_VARIATION_REF: u32 = 1; pub const VIEW_CONTAINER_TYPE_VARIATION_REF: u32 = 2; +/// Used for the arrow type [`DataType::Map`]. +/// +/// [`DataType::Map`]: datafusion::arrow::datatypes::DataType::Map +pub const DICTIONARY_CONTAINER_TYPE_VARIATION_REF: u32 = 3; Review Comment: Yeah I 100% agree, I've updated it use the consts you've suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
