timsaucer opened a new pull request, #1187:
URL: https://github.com/apache/datafusion-python/pull/1187
# Which issue does this PR close?
None
# Rationale for this change
This is a relatively minor change that allows users to pass a single
expression for `order_by` and `partition_by` fields.
Without this change, if used improperly planning gets stuck in a loop. This
improves ergonomics.
Old version required:
```python
df.select(f.lag(column("a"), order_by=[column("b")])
```
and now you can also write
```python
df.select(f.lag(column("a"), order_by=column("b"))
```
# What changes are included in this PR?
Enhances the check to see if we pass a single expression. When this is true,
wrap it in a list. Added unit tests.
# Are there any user-facing changes?
This is a non-breaking signature change. It is backwards compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
