alamb opened a new pull request, #16730:
URL: https://github.com/apache/datafusion/pull/16730

   ## Which issue does this PR close?
   
   - Part of https://github.com/apache/datafusion/issues/16729
   
   
   ## Rationale for this change
   
   These benchmarks are not used, and are done against synthetic data, and do 
not seem to measure the impact of filter pushdown or sort in a meaningful way. 
See additional rationale here:
   - https://github.com/apache/datafusion/issues/16729
   
   1. To test filter pushdown we use the clickbench queries
   2. To test sorting we use the `sort_tpch` benchmark
   
   Also the name `parquet` as the benchmark is misleading as it is supposed to 
be for parquet filter pushdown
   
   For example of this test adding 
https://github.com/apache/datafusion/pull/16711#issuecomment-3052934882
   
   Let's remove these benchmarks and make a new one using the clickbench 
queries and data
   
   ## What changes are included in this PR?
   
   1. remove two unused benchmarks 
   
   ## Are these changes tested?
   
   By CI and I tested that bench.sh still works 
   
   ## Are there any user-facing changes?
   
   No (as I don't think these were ever used)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to