2010YOUY01 commented on PR #16443: URL: https://github.com/apache/datafusion/pull/16443#issuecomment-3056490809
> I have addressed all of your comments. @2010YOUY01 please take another look > > > I recommend to doc more high-level ideas to key functions, to make this module easier to maintain in the future, specifically: `build_unmatched_output()`, `prepare_unmatched_output_indices()`, and `get_next_join_result()` > > Since the logic of `build_unmatched_output` is quite straightforward, I don't think it's necessary to add extra documentation. I've now added documentation for the other two functions I'm starting a second pass. I haven't fully grasped the internal logic of `get_next_join_result()` for the special join types yet, but I’ll continue soon. I think documenting the semantics of left/right indices for different join types can help readability, like - For inner joins: left and right indices should all be valid - For left/right/full joins: left and right indices can use null to represent unmatched rows - Question: do we have other special semantics for semi/anti/mark joins? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
