alamb commented on code in PR #16732:
URL: https://github.com/apache/datafusion/pull/16732#discussion_r2197549066
##########
datafusion/physical-plan/src/filter_pushdown.rs:
##########
@@ -95,13 +95,110 @@ pub enum PredicateSupport {
}
impl PredicateSupport {
+ /// Return the wrapped expression, discarding whether it is supported or
unsupported.
pub fn into_inner(self) -> Arc<dyn PhysicalExpr> {
match self {
PredicateSupport::Supported(expr) |
PredicateSupport::Unsupported(expr) => {
expr
}
}
}
+
+ /// Convert the [`PredicateSupport`] into a
[`PredicateSupportDiscriminant`].
+ pub fn discriminant(&self) -> PredicateSupportDiscriminant {
Review Comment:
Maybe PredicateSupport would be easier to manage if it was a struct with a
discrimnant field rather than an enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
