colinmarc opened a new issue, #16749: URL: https://github.com/apache/datafusion/issues/16749
### Describe the bug `LogicalExtensionCodec` allows providing a custom serialization strategy for a `TableProvider`, but the calling code always expects a `DefaultTableSource` to unwrap: https://github.com/apache/datafusion/blob/8d7b11b1cdf04aa9e7c402b5c97e45240e6e71a0/datafusion/proto/src/logical_plan/mod.rs#L1004 Which calls `source_as_provider`: https://github.com/apache/datafusion/blob/8d7b11b1cdf04aa9e7c402b5c97e45240e6e71a0/datafusion/catalog/src/default_table_source.rs#L99-L110 It would be better if `LogicalExtensionCodec` had `encode_table_source` instead of `encode_table_provider`. ### To Reproduce _No response_ ### Expected behavior _No response_ ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
