colinmarc opened a new pull request, #16750:
URL: https://github.com/apache/datafusion/pull/16750
Currently, only instances of `TableProvider` are considered by
`LogicalExtensionCodec`, and are automatically wrapped in a
`DefaultTableSource` when deserializing. That doesn't work with custom
extensions.
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #16749.
## Rationale for this change
It's currently impossible to serialize/deserialize custom `TableSource`
implementations with `LogicalExtensionCodec`.
## What changes are included in this PR?
`LogicalExtensionCodec` is changed to have a `try_{en,de}code_table_source`
instead of `table_provider`. This is a breaking change.
## Are these changes tested?
This is covered by existing serde tests.
## Are there any user-facing changes?
Yes, implementors of `LogicalExtensionCodec` downstream will be affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
