haohuaijin commented on code in PR #16733:
URL: https://github.com/apache/datafusion/pull/16733#discussion_r2196439508
##########
datafusion/physical-plan/src/aggregates/group_values/mod.rs:
##########
@@ -121,13 +121,15 @@ pub(crate) trait GroupValues: Send {
/// will be chosen.
///
/// - If group by multiple columns, and all column types have the specific
-/// [`GroupColumn`] implementations, [`GroupValuesColumn`] will be chosen.
+/// `GroupColumn` implementations, `GroupValuesColumn` will be chosen.
///
-/// - Otherwise, the general implementation [`GroupValuesRows`] will be
chosen.
+/// - Otherwise, the general implementation `GroupValuesRows` will be chosen.
///
-/// [`GroupColumn`]:
crate::aggregates::group_values::multi_group_by::GroupColumn
+/// `GroupColumn`:
crate::aggregates::group_values::multi_group_by::GroupColumn
+/// `GroupValuesColumn`:
crate::aggregates::group_values::multi_group_by::GroupValuesColumn
+/// `GroupValuesRows`: crate::aggregates::group_values::row::GroupValuesRows
Review Comment:
remove the `[]` to pass the `cargo doc` ci, because `GroupValuesColumn` and
`GroupValuesRows` are private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
