colinmarc commented on issue #1181: URL: https://github.com/apache/datafusion-python/issues/1181#issuecomment-3065994600
> I have thought of two approaches... Either of these seems plausible to me! It still seems like a shame that the `LogicalExtensionCodec` has to be written with `ForeignTableProvider` in mind, but I'm not sure I see a better way. Perhaps we could "upstream" the magic number / ID thing to datafusion proper so that you only have to write `LogicalExtensionCodec` to consider the magic number, and not do the `downcast_ref` pattern at all. That would also be useful for the decode flow - it could be stored on the `CustomTableScan` proto representation and passed to `try_decode_table_provider`. By the way, I have a PR up to change the encode/decode flow to deal with `TableSource` implementations, not `TableProvider`s directly: https://github.com/apache/datafusion/pull/16750. I don't think that should affect this work much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
