kosiew opened a new pull request, #16782:
URL: https://github.com/apache/datafusion/pull/16782

   ## Which issue does this PR close?
   
   - Closes #16767
   
   ## Rationale for this change
   
   This refactor improves the organization and maintainability of the type 
coercion tests in the `datafusion/expr-common` crate.  
   By grouping related tests into separate modules (`arithmetic.rs`, 
`comparison.rs`, `dictionary.rs`, `null_coercion.rs`), it makes the test suite 
easier to navigate, extend, and review.
   
   ## What changes are included in this PR?
   
   - Moved all existing tests from `binary.rs` into dedicated submodules under 
`binary/tests/`
     - `arithmetic.rs` — arithmetic coercion and numeric tests
     - `comparison.rs` — comparison, like, binary ops, map and list coercion 
tests
     - `dictionary.rs` — dictionary coercion tests
     - `null_coercion.rs` — logical ops and null coercion tests
   - Extracted common test macros into `tests/mod.rs`
   - Ensured no test coverage was dropped during the move
   
   ## Are these changes tested?
   
   ✅ Yes — This PR only reorganizes existing, already tested code.  
   All tests continue to run under the new module structure.
   
   ## Are there any user-facing changes?
   
   ❌ No — This is an internal refactor of test code only.  
   There are no changes to user-facing APIs or behavior.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to