Omega359 commented on code in PR #16780:
URL: https://github.com/apache/datafusion/pull/16780#discussion_r2207320436
##########
datafusion/spark/src/function/datetime/mod.rs:
##########
@@ -15,11 +15,24 @@
// specific language governing permissions and limitations
// under the License.
+pub mod next_day;
+
use datafusion_expr::ScalarUDF;
+use datafusion_functions::make_udf_function;
use std::sync::Arc;
-pub mod expr_fn {}
+make_udf_function!(next_day::SparkNextDay, next_day);
+
+pub mod expr_fn {
+ use datafusion_functions::export_functions;
+
+ export_functions!((
+ next_day,
+ "Returns the first date which is later than start_date and named as
indicated. The function returns NULL if at least one of the input parameters is
NULL. When both of the input parameters are not NULL and day_of_week is an
invalid input, the function throws SparkIllegalArgumentException if
spark.sql.ansi.enabled is set to true, otherwise NULL.",
Review Comment:
I think this needs to be adjusted. Rust does not have exceptions and ansi
mode is not hooked up yet (might need something like
https://github.com/apache/datafusion/pull/16661 for that to happen)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
