alamb commented on code in PR #16783:
URL: https://github.com/apache/datafusion/pull/16783#discussion_r2208603160
##########
datafusion/datasource/src/statistics.rs:
##########
@@ -230,14 +230,7 @@ impl MinMaxStatistics {
.zip(sort_columns.iter().copied())
.map(|(sort_expr, column)| {
let schema = values.schema();
-
Review Comment:
This appears to be the only actual code change: remove these lines
`git praise` says they came in via #9593 from @suremarc . Do you remember
why this condition was added @suremarc ?
https://github.com/apache/datafusion/blame/a614716e7d97ff1d3374aef31b9a66fd10141423/datafusion/datasource/src/statistics.rs#L238
##########
datafusion/sqllogictest/test_files/parquet.slt:
##########
@@ -130,8 +130,7 @@ STORED AS PARQUET;
----
3
-# Check output plan again, expect no "output_ordering" clause in the
physical_plan -> ParquetExec,
-# due to there being more files than partitions:
+# Check output plan again
Review Comment:
I agree -- I reviewed the test and the table definition explicitly says
```sql
WITH ORDER (string_col ASC NULLS LAST, int_col ASC NULLS LAST)
```
So I would expect this plan not to have additional sorting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
