andygrove commented on code in PR #2010: URL: https://github.com/apache/datafusion-comet/pull/2010#discussion_r2215684316
########## native/proto/src/proto/expr.proto: ########## @@ -80,7 +80,8 @@ message Expr { ArrayInsert array_insert = 58; MathExpr integral_divide = 59; ToPrettyString to_pretty_string = 60; - UnaryExpr rand = 61; + Rand rand = 61; + Randn randn = 62; Review Comment: The Rand struct could be used here rather than define an identical Randn struct. ```suggestion Rand randn = 62; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org