chenkovsky commented on PR #16824:
URL: https://github.com/apache/datafusion/pull/16824#issuecomment-3092159015
another way is to add default aws config file, and set AWS_CONFIG_FILE env.
But I found that s3_object_store_builder_default will fail, on assert:
```rust
assert_eq!(
builder.get_config_value(&AmazonS3ConfigKey::SkipSignature),
expected_skip_signature
);
```
maybe this assert is incorrect or there's a bug.
in current implementation,
```rust
if let Some(credentials) = credentials {
let credentials = Arc::new(S3CredentialProvider { credentials });
builder = builder.with_credentials(credentials);
} else {
debug!("No credentials found, defaulting to skip signature ");
builder = builder.with_skip_signature(true);
}
```
If credentials are found, skip_signature won't be toggled on.
But in test, if there are no AK and SK, skip_signature is expected to be
toggled on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
