Huy1Ng commented on code in PR #1275:
URL:
https://github.com/apache/datafusion-ballista/pull/1275#discussion_r2217686513
##########
.github/workflows/rust.yml:
##########
@@ -17,275 +17,151 @@
name: Rust
+concurrency:
+ group: ${{ github.repository }}-${{ github.workflow }}
+ cancel-in-progress: true
+
on:
# always trigger
push:
pull_request:
jobs:
- # build the library, a compilation step used by multiple steps below
+ # Check crate compiles and base cargo check passes
linux-build-lib:
- name: Build Libraries on AMD64 Rust ${{ matrix.rust }}
+ name: linux build test
runs-on: ubuntu-latest
- strategy:
- matrix:
- arch: [amd64]
- rust: [stable]
container:
- image: ${{ matrix.arch }}/rust
- env:
- # Disable full debug symbol generation to speed up CI build and keep
memory down
- # "1" means line tables only, which is useful for panic tracebacks.
- RUSTFLAGS: "-C debuginfo=1"
+ image: amd64/rust
steps:
- uses: actions/checkout@v4
- - name: Cache Cargo
- uses: actions/cache@v4
- with:
- # these represent dependencies downloaded by cargo
- # and thus do not depend on the OS, arch nor rust version.
- path: /github/home/.cargo
- key: cargo-cache-
- - name: Cache Rust dependencies
- uses: actions/cache@v4
with:
- # these represent compiled steps of both dependencies and arrow
- # and thus are specific for a particular OS, arch and rust version.
- path: /github/home/target
- key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{
matrix.rust }}-
+ submodules: true
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
- with:
- rust-version: ${{ matrix.rust }}
- - name: Build workspace in release mode
+ - name: Prepare cargo build
run: |
- cargo build --release
- ls -l /github/home/target/release
- env:
- CARGO_HOME: "/github/home/.cargo"
- CARGO_TARGET_DIR: "/github/home/target"
- - name: Save artifacts
- uses: actions/upload-artifact@v4
- with:
- name: rust-artifacts
- path: |
- /github/home/target/release/ballista-scheduler
- /github/home/target/release/ballista-executor
+ # Adding `--locked` here to assert that the `Cargo.lock` file is up
to
+ # date with the manifest. When this fails, please make sure to commit
+ # the changes to `Cargo.lock` after building with the updated
manifest.
+ cargo check --profile ci --workspace --all-targets --locked
- # test the crate
linux-test:
- name: Test Workspace on AMD64 Rust ${{ matrix.rust }}
- needs: [linux-build-lib]
+ name: test linux crates
runs-on: ubuntu-latest
- strategy:
- matrix:
- arch: [amd64]
- rust: [stable]
container:
- image: ${{ matrix.arch }}/rust
- env:
- # Disable full debug symbol generation to speed up CI build and keep
memory down
- # "1" means line tables only, which is useful for panic tracebacks.
- RUSTFLAGS: "-C debuginfo=1"
+ image: amd64/rust
steps:
- uses: actions/checkout@v4
with:
submodules: true
- - name: Install protobuf compiler
- shell: bash
- run: |
- apt-get -qq update && apt-get -y -qq install protobuf-compiler
- protoc --version
- - name: Cache Cargo
- uses: actions/cache@v4
- with:
- path: /github/home/.cargo
- # this key equals the ones on `linux-build-lib` for re-use
- key: cargo-cache-
- - name: Cache Rust dependencies
- uses: actions/cache@v4
- with:
- path: /github/home/target
- # this key equals the ones on `linux-build-lib` for re-use
- key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{
matrix.rust }}
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
- with:
- rust-version: ${{ matrix.rust }}
- name: Run tests
run: |
export PATH=$PATH:$HOME/d/protoc/bin
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- cargo test --features=testcontainers
+ cargo test --profile ci --features=testcontainers
env:
CARGO_HOME: "/github/home/.cargo"
CARGO_TARGET_DIR: "/github/home/target"
+
+ linux-build-workspace:
+ name: check linux workspace
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ submodules: true
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
- name: Try to compile when `--no-default-features` is selected
run: |
export PATH=$PATH:$HOME/d/protoc/bin
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- cargo build -p ballista-scheduler -p ballista-executor -p
ballista-core -p ballista --no-default-features
+ cargo check --profile ci -p ballista-scheduler -p ballista-executor
-p ballista-core -p ballista --no-default-features --locked
env:
CARGO_HOME: "/github/home/.cargo"
CARGO_TARGET_DIR: "/github/home/target"
- # run ballista tests
ballista-test:
- name: Test Ballista on AMD64 Rust ${{ matrix.rust }}
- needs: [linux-build-lib]
+ name: test linux balista
runs-on: ubuntu-latest
- strategy:
- matrix:
- arch: [amd64]
- rust: [stable]
container:
- image: ${{ matrix.arch }}/rust
- env:
- # Disable full debug symbol generation to speed up CI build and keep
memory down
- # "1" means line tables only, which is useful for panic tracebacks.
- RUSTFLAGS: "-C debuginfo=1"
+ image: amd64/rust
steps:
- uses: actions/checkout@v4
with:
submodules: true
- - name: Install protobuf compiler
- shell: bash
- run: |
- mkdir -p $HOME/d/protoc
- cd $HOME/d/protoc
- export PROTO_ZIP="protoc-21.4-linux-x86_64.zip"
- curl -LO
https://github.com/protocolbuffers/protobuf/releases/download/v21.4/$PROTO_ZIP
- unzip $PROTO_ZIP
- export PATH=$PATH:$HOME/d/protoc/bin
- protoc --version
- - name: Cache Cargo
- uses: actions/cache@v4
- with:
- path: /github/home/.cargo
- # this key equals the ones on `linux-build-lib` for re-use
- key: cargo-cache-
- - name: Cache Rust dependencies
- uses: actions/cache@v4
- with:
- path: /github/home/target
- # this key equals the ones on `linux-build-lib` for re-use
- key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{
matrix.rust }}
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
- with:
- rust-version: ${{ matrix.rust }}
- # Ballista is currently not part of the main workspace so requires a
separate test step
- name: Run Ballista tests
run: |
export PATH=$PATH:$HOME/d/protoc/bin
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
cd ballista
# Ensure also compiles in standalone mode
- cargo test --no-default-features --features standalone
+ cargo test --profile ci --no-default-features --features standalone
--locked
env:
CARGO_HOME: "/github/home/.cargo"
CARGO_TARGET_DIR: "/github/home/target"
- windows-and-macos:
- name: Test on ${{ matrix.os }} Rust ${{ matrix.rust }}
- runs-on: ${{ matrix.os }}
- strategy:
- matrix:
- os: [windows-latest, macos-latest]
- rust: [stable]
+ windows-test:
+ name: windows test
+ runs-on: windows-latest
steps:
- uses: actions/checkout@v4
with:
submodules: true
- - name: Install protobuf macos compiler
- shell: bash
- run: |
- mkdir -p $HOME/d/protoc
- cd $HOME/d/protoc
- export PROTO_ZIP="protoc-21.4-osx-x86_64.zip"
- curl -LO
https://github.com/protocolbuffers/protobuf/releases/download/v21.4/$PROTO_ZIP
- unzip $PROTO_ZIP
- echo "$HOME/d/protoc/bin" >> $GITHUB_PATH
- export PATH=$PATH:$HOME/d/protoc/bin
- protoc --version
- if: ${{matrix.os == 'macos-latest'}}
- - name: Install protobuf windows compiler
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-windows-builder
+ - name: Run tests
shell: bash
run: |
- mkdir -p $HOME/d/protoc
- cd $HOME/d/protoc
- export PROTO_ZIP="protoc-21.4-win64.zip"
- curl -LO
https://github.com/protocolbuffers/protobuf/releases/download/v21.4/$PROTO_ZIP
- unzip $PROTO_ZIP
export PATH=$PATH:$HOME/d/protoc/bin
- protoc.exe --version
- if: ${{matrix.os == 'windows-latest'}}
- # TODO: this won't cache anything, which is expensive. Setup this action
- # with a OS-dependent path.
+ export ARROW_TEST_DATA=$(pwd)/testing/data
+ export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
+ export TMP=$(pwd)/.temp
+ mkdir -p "$TMP"
+ cargo test --profile ci --locked
+
+ macos-test:
+ name: macos test
+ runs-on: macos-latest
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ submodules: true
- name: Setup Rust toolchain
- run: |
- rustup toolchain install ${{ matrix.rust }}
- rustup default ${{ matrix.rust }}
- rustup component add rustfmt
+ uses: ./.github/actions/setup-macos-builder
- name: Run tests
shell: bash
run: |
export PATH=$PATH:$HOME/d/protoc/bin
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- export TMP=$(pwd)/.temp
- mkdir -p "$TMP"
- cargo test
- env:
- # do not produce debug symbols to keep memory usage down
- RUSTFLAGS: "-C debuginfo=0"
+ cargo test --profile ci --locked
# verify that the benchmark queries return the correct results
verify-benchmark-results:
name: verify benchmark results (amd64)
- needs: [linux-build-lib]
runs-on: ubuntu-latest
- strategy:
- matrix:
- arch: [amd64]
- rust: [stable]
container:
- image: ${{ matrix.arch }}/rust
- env:
- # Disable full debug symbol generation to speed up CI build and keep
memory down
- # "1" means line tables only, which is useful for panic tracebacks.
- RUSTFLAGS: "-C debuginfo=1"
+ image: amd64/rust
steps:
- uses: actions/checkout@v4
with:
submodules: true
- - name: Install protobuf compiler
- shell: bash
- run: |
- apt-get -qq update && apt-get -y -qq install protobuf-compiler
- protoc --version
- - name: Cache Cargo
- uses: actions/cache@v4
- with:
- path: /github/home/.cargo
- # this key equals the ones on `linux-build-lib` for re-use
- key: cargo-cache-
- - name: Cache Rust dependencies
Review Comment:
I also wonder if benchmark test is where we should leave the caching. This
is the bottleneck of rust workflows, so any optimization would help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
