theirix commented on code in PR #16831:
URL: https://github.com/apache/datafusion/pull/16831#discussion_r2218529490
##########
datafusion/optimizer/src/simplify_expressions/utils.rs:
##########
@@ -17,54 +17,14 @@
//! Utility functions for expression simplification
+use arrow::datatypes::i256;
use datafusion_common::{internal_err, Result, ScalarValue};
use datafusion_expr::{
expr::{Between, BinaryExpr, InList},
expr_fn::{and, bitwise_and, bitwise_or, or},
Expr, Like, Operator,
};
-pub static POWS_OF_TEN: [i128; 38] = [
Review Comment:
Let me conduct some tests. It could also have been introduced for clarity,
too.
`i128` and `i256` pow are not hardware-backed (with `i256` introducing
non-trivial low/high logic), so it's probably better to precompute lists via a
`const` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
