iffyio commented on code in PR #1953:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1953#discussion_r2218894873
##########
src/parser/mod.rs:
##########
@@ -2016,6 +2018,46 @@ impl<'a> Parser<'a> {
})
}
+ // Tries to parse the body of an [ODBC escaping sequence]
Review Comment:
```suggestion
/// Tries to parse the body of an [ODBC escaping sequence]
```
##########
tests/sqlparser_common.rs:
##########
@@ -16174,3 +16199,13 @@ fn test_identifier_unicode_start() {
]);
let _ = dialects.verified_stmt(sql);
}
+
+#[test]
+fn test_odbc_time_date_timestamp_support() {
+ let sql_d = "SELECT {d '2025-07-17'}, category_name FROM categories";
Review Comment:
Could we include a negative test for an expression that doesn't use the
expected character? e.g. `SELECT {tt '14:12:01'} FROM foo`
##########
src/parser/mod.rs:
##########
@@ -2016,6 +2018,46 @@ impl<'a> Parser<'a> {
})
}
+ // Tries to parse the body of an [ODBC escaping sequence]
Review Comment:
> [ODBC escaping sequence]
Can we include a doc link referencing this part of the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
